Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AK: Decode paired UTF-16 surrogates in a JSON string #24678

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

Hendiadyoin1
Copy link
Contributor

For example, such use is seen on Twitter.


Cherry-Picked from: LadybirdBrowser/ladybird#369

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 7, 2024
@Hendiadyoin1 Hendiadyoin1 force-pushed the json_unicode branch 2 times, most recently from bc7d026 to 0b2667e Compare July 7, 2024 13:59
@nico
Copy link
Contributor

nico commented Jul 7, 2024

Could you use git cherry-pick -x?

We will want to use the exact behavior of these methods in JsonParser.

(cherry picked from commit c39a3fef17e913da944c35d57541298232bcea53)
For example, such use is seen on Twitter.

(cherry picked from commit 698a95d2dee0ba7e9a3f1c39af5459ba506c445f)
@Hendiadyoin1
Copy link
Contributor Author

I think that worked
(note that I needed to slightly adjust the first commit to retain the Kernel checks)

@nico nico merged commit 8adcbd7 into SerenityOS:master Jul 7, 2024
11 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 7, 2024
@Hendiadyoin1 Hendiadyoin1 deleted the json_unicode branch July 7, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants