LibWasm+AK: Sync Wasm changes from ladybird #24682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fce8ed15630a4969be7c9761b9b7d3cef0530cc6)
A `Uint8Array` can now be passed in the Wasm testjs files to be transmuted into a Wasm value. (cherry picked from commit 6493acf2f46f6e4522a0f1f01e12d0e48347562e)
NaN bit patterns are now (hopefully) preserved. `static_cast` does not preserve the bit pattern of a given NaN, so ideally we'd use some other sort of cast and avoid `static_cast` altogether, but that's a large change for this commit. For now, this fixes the issues found in spec tests. (cherry picked from commit c882498d4450c4c2e46d77a8ab36afc4eb412c00)
(cherry picked from commit c103001f167d39fd68c4f04649332f76b7dd0b2e)
According to the spec, -0.0 < 0.0. (cherry picked from commit 31c7e98a4a46c2d0ef93c5fca47d64d05b96449f)
As far as I know, they're not in the spec and don't serve any purposes in the internals of LibWasm. (cherry picked from commit 5382fbb6171555264e29872029330e1373b39671)
Simply returns how many bytes can be read from the stream. (cherry picked from commit aee2f25929157a4e6c7f391584c4839a40beadc8)
(cherry picked from commit afd8d90f3237e0cffaabb05becbff16f8c8fdd25)
https://webassembly.github.io/spec/js-api/index.html#name-of-the-webassembly-function (cherry picked from commit e8fd8982f82e91f97b24523f3ee60eef774990dd)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry-picked)