LibJS: Implement extract_pointer_bits for ppc64 #24685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On PowerPC 64 pointers can use all 64 bits, however by convention on Linux user-space addresses use only the lower 43 bits. I'm not 100% certain that the masking off of the 16 high bits is the proper solution, but it matches the rest of the LibJS code which assumes pointers only use the lower 48 bits. https://www.kernel.org/doc/ols/2001/ppc64.pdf
github-actions
bot
added
the
👀 pr-needs-review
|
I was too fast. This PR requires #24684 to be merged, first. |
github-actions
bot
removed
the
👀 pr-needs-review
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PowerPC 64 pointers can use all 64 bits, however by convention on Linux user-space addresses use only the lower 43 bits. I'm not 100% certain that the masking off of the 16 high bits is the proper solution, but it matches the rest of the LibJS code which assumes pointers only use the lower 48 bits.
https://www.kernel.org/doc/ols/2001/ppc64.pdf
This is a copy of LadybirdBrowser/ladybird#504 and has not been tested in SerenityOS, because I don't have a system running SerenityOS.