AK: Fix {:c} formatter for big-endian #24686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just casting an integer type to a char pointer does not work on big endian.
Instead, the value needs to be properly converted into a char.
I uncommented the 7-bit ASCII check while at it. I think it's better to be safer than necessary to spot cases where high ASCII/UTF-8 support would be needed earlier.
This is a copy of LadybirdBrowser/ladybird#434 and has not been tested in SerenityOS, because I don't have a system running SerenityOS.