Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Sort Events by start DateTime #24690

Merged

Conversation

alec3660
Copy link
Contributor

This PR allows Calendar to display Events in chronological order.

Before:

before-screenshot

After:

after-screenshot

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 10, 2024
@AtkinsSJ
Copy link
Member

First, thanks for fixing this!

Second, I'm assuming you didn't know, but we do have a quick_sort() implementation. I don't know if you're doing something really clever that I don't understand, but otherwise, using quick_sort() would be clearer.

This PR allows Calendar to display Events in chronological order.
@alec3660 alec3660 force-pushed the calendar-sort-events-by-start-datetime branch from 8f9e109 to 1add641 Compare July 10, 2024 20:04
@alec3660
Copy link
Contributor Author

First, thanks for fixing this!

Second, I'm assuming you didn't know, but we do have a quick_sort() implementation. I don't know if you're doing something really clever that I don't understand, but otherwise, using quick_sort() would be clearer.

I was aware of the quick_sort() implementation but I wasn't sure if it was compatible with some other features that I am working on. It turns out I was overthinking things and it works great, thanks!

@AtkinsSJ AtkinsSJ merged commit 1dca789 into SerenityOS:master Jul 11, 2024
11 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 11, 2024
@alec3660 alec3660 deleted the calendar-sort-events-by-start-datetime branch July 11, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants