-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta: Pretty-printing enhancements #24691
Meta: Pretty-printing enhancements #24691
Conversation
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
This fixes pretty-printing of AK::HashMap, and adds pretty-printing of AK::IntrusiveList
91b4d6d
to
d4e0d98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I don't use this file myself, so I'll trust you that the change works :) One stylistic comment below:
return '""' | ||
else: | ||
return self.val["m_characters"].string(length=self.val["m_length"]) | ||
return self.val["m_characters"].string(length=self.val["m_length"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention StringView in commit description too.
Actually, could you do one commit per thing?
- One for adding IntrusiveList
- One for fixing HashMap (add some more words on what exactly it fixes, see https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md
Don't Use weasel-words like "refactor" or "fix" to avoid explaining what's being changed.
) - One for StringView, saying what exactly is changing here (I think this here is meant to be a no-op)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions! |
This fixes pretty-printing of AK::HashMap, and adds pretty-printing of AK::IntrusiveList