Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Pretty-printing enhancements #24691

Closed

Conversation

sleirsgoevy
Copy link
Contributor

This fixes pretty-printing of AK::HashMap, and adds pretty-printing of AK::IntrusiveList

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jul 11, 2024
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

This fixes pretty-printing of AK::HashMap, and adds pretty-printing of
AK::IntrusiveList
Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't use this file myself, so I'll trust you that the change works :) One stylistic comment below:

return '""'
else:
return self.val["m_characters"].string(length=self.val["m_length"])
return self.val["m_characters"].string(length=self.val["m_length"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention StringView in commit description too.

Actually, could you do one commit per thing?

  • One for adding IntrusiveList
  • One for fixing HashMap (add some more words on what exactly it fixes, see https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md Don't Use weasel-words like "refactor" or "fix" to avoid explaining what's being changed.)
  • One for StringView, saying what exactly is changing here (I think this here is meant to be a no-op)

@nico nico added ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Jul 12, 2024
Copy link

stale bot commented Aug 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Aug 3, 2024
Copy link

stale bot commented Aug 10, 2024

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

@stale stale bot closed this Aug 10, 2024
@github-actions github-actions bot removed the ⏳ pr-waiting-for-author PR is blocked by feedback / code changes from the author label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants