LibELF: Fix incorrect treatment of DT_REL&DT_RELA #24693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
In the current code, these are treated as if they were a bitmap. They are not, and (DT_REL & DT_RELA) is actually nonzero. This causes the linker to treat all sections as having addends, which is not correct.
sleirsgoevy
force-pushed
the
libelf-fix-dt-rel
branch
from
d0569ac
to
c5494f6
Compare
sleirsgoevy
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, these are treated as if they were a bitmap. They are not, and (DT_REL & DT_RELA) is actually nonzero. This causes the linker to treat all sections as having addends, which is not correct.