Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel/FileSystem: Small code cleanups #24760

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Kernel/FileSystem: Small code cleanups #24760

merged 2 commits into from
Jul 27, 2024

Commits on Jul 27, 2024

  1. Kernel/FileSystem: Change const placement to match style guide 

    This moves 3 const keywords in OpenFileDescription::tty() to make them
consistent with the 'const placement' rule in the style guide.
    @brody-qq
    brody-qq committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    3338b94 View commit details
    Browse the repository at this point in the history

  2. Kernel/Ext2FS: Replace hardcoded offset with a constexpr 

    The superblock of an ext2 filesystem is always found on the storage
device at offset 1024. This 1024 number was hardcoded in the Ext2FS
code.

This commit:
* adds a constexpr to replace the hardcoded 1024 values
* removes a comment about one of the the hardcoded 1024 values which is
  now umnecessary
    @brody-qq
    brody-qq committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    ac37484 View commit details
    Browse the repository at this point in the history