AK: Introduce IPAddressCidr datatype by famfo · Pull Request #25006 · SerenityOS/serenity

famfo · 2024-09-09T17:55:42Z

This commit introduces a CIDR datatype which will become handy especially for IPv6 to not have to deal with netmasks.

kleinesfilmroellchen

(note to other reviewers: this is part of SIP6TF, so I was consulted on quite a bit of this code and may be biased)

Very nice work, and extensive tests, I like it. I'm not happy with the name though, so some bikeshedding may be required.

Hendiadyoin1

Mainly Nits on my end, that would likely need support from other places in the code base to resolve

Hendiadyoin1 · 2024-09-10T08:27:10Z

I'd prefer CIDR

Hendiadyoin1 · 2024-09-10T08:36:06Z

+        auto address_string = TRY(m_address.to_string());
+
+#ifdef KERNEL
+        TRY(builder.try_append(address_string->view()));
+#else
+        TRY(builder.try_append(address_string));
+#endif
+
+        TRY(builder.try_append('/'));
+        TRY(builder.try_appendff("{}", m_length));


Ideally this would just be a

#ifdef KERNEL return KSting::formatted("{}/{}", m_address, m_length()); #else return Sting::try_formatted("{}/{}", m_address, m_length()); #endif

but we're likely missing a custom formatter, are we?
Note that fallibility in the Userland case is not enforced (anymore)

Just doing

#ifdef KERNEL ErrorOr<NonnullOwnPtr<Kernel::KString>> to_string() const { return KString::formatted("{}/{}", m_address, m_length); } #else ErrorOr<String> to_string() const { return String::formatted("{}/{}", m_address, m_length); } #endif

works is this case both for IPv4 and IPv6 in hosts and serenity tests. I'll adopt this for formatting.

Hendiadyoin1 · 2024-09-10T09:01:53Z

+template<>
+struct Formatter<IPv6AddressCidr> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, IPv6AddressCidr value)
+    {
+        return Formatter<StringView>::format(builder, TRY(value.to_string())->view());
+    }
+};
+#else
+template<>
+struct Formatter<IPv6AddressCidr> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, IPv6AddressCidr value)
+    {
+        return Formatter<StringView>::format(builder, TRY(value.to_string()));
+    }
+};


See the OG commit

What I meant with this, is that this could mirror the actual implementation of the CIDR to_string method,
maybe even replace it.

With some template shenanigans (Ie DerivedFrom<IpAddressCIDR>) all formatters could use the same code

Hendiadyoin1 · 2024-09-10T09:02:11Z

+template<>
+struct Formatter<IPv4AddressCidr> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, IPv4AddressCidr value)
+    {
+        return Formatter<StringView>::format(builder, TRY(value.to_string())->view());
+    }
+};
+#else
+template<>
+struct Formatter<IPv4AddressCidr> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, IPv4AddressCidr value)
+    {
+        return Formatter<StringView>::format(builder, TRY(value.to_string()));
+    }
+};


See OG commit

BuggieBot · 2024-09-10T13:49:43Z

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

famfo · 2024-09-10T13:51:05Z

I will squash this again later when the code itself is fine

kleinesfilmroellchen

Only Leon's comment about string formatting needs to be resolved, I think we want to switch the implementation place and move the implementation into the Formatter, while to_string only calls String::formatted.

stale · 2024-11-05T03:30:23Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

famfo · 2024-11-07T13:34:51Z

I will pick this up again eventually, currently a bit short on time unfortunately.

stale · 2024-12-06T04:06:28Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale · 2025-01-18T07:50:43Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale · 2025-01-25T17:11:30Z

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

github-actions Bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Sep 9, 2024

kleinesfilmroellchen suggested changes Sep 9, 2024

View reviewed changes

famfo added 3 commits September 10, 2024 00:59

AK: Add IPAddressCidr datatype

0ee7daa

AK/IpAddressCidr: Add IPv4AddressCidr

1103339

AK/IpAddressCidr: Add IPv6AddressCidr

695a66a

famfo force-pushed the IPAddressCidr branch from 3329767 to 695a66a Compare September 9, 2024 23:08

Hendiadyoin1 reviewed Sep 10, 2024

View reviewed changes

famfo added 3 commits September 10, 2024 15:43

fixup! Base: use more auto, change fromatting

76bfe74

fixup! IPv4: move MAX_LENGTH to the top

bcf16e1

fixup! IPv6: move MAX_LENGTH to top, return IPv6Address explicitly

203e4bf

famfo added 2 commits September 11, 2024 01:17

fixup: Base: use release_value

b754b80

fixup: IPv6: use release_value

5b792e9

famfo marked this pull request as draft September 10, 2024 23:25

github-actions Bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Sep 10, 2024

famfo added 2 commits September 13, 2024 03:29

AK/IPv6Address: Add to and from u128 functions

074cf8a

fixup: IPv6: use u128 datatypes

06fea38

timschumi reviewed Sep 27, 2024

View reviewed changes

famfo added 5 commits September 27, 2024 23:53

fixup! Base class: implement formatter for IPAddressCidrError

21e6d63

fixup! IPv6AddressCidr: use TRY_OR_FAIL, use C++ casts

6350122

fixup! IPv4AddressCidr: use TRY_OR_FAIL, use C++ casts

9327500

fixup! TestIPv6Address: use C++ casts

7aa69d4

fixup! Base: clang-format

d1b9e2c

famfo force-pushed the IPAddressCidr branch from 28ead4b to d1b9e2c Compare September 27, 2024 22:17

AK/Error: Mark ErrorOr constructor as contexpr

12d20e4

famfo marked this pull request as ready for review September 28, 2024 22:20

github-actions Bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Sep 28, 2024

kleinesfilmroellchen reviewed Oct 2, 2024

View reviewed changes

stale Bot added the stale label Nov 5, 2024

stale Bot removed the stale label Nov 7, 2024

stale Bot added the stale label Dec 6, 2024

kleinesfilmroellchen removed the stale label Dec 27, 2024

stale Bot added the stale label Jan 18, 2025

stale Bot closed this Jan 25, 2025

github-actions Bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jan 25, 2025

kleinesfilmroellchen mentioned this pull request Mar 11, 2025

AK: Make Optional and ErrorOr constexpr #25740

Merged

Conversation

famfo commented Sep 9, 2024

Uh oh!

kleinesfilmroellchen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hendiadyoin1 left a comment

Choose a reason for hiding this comment

Uh oh!

Hendiadyoin1 Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Hendiadyoin1 Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

famfo Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hendiadyoin1 Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Hendiadyoin1 Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

Hendiadyoin1 Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

BuggieBot commented Sep 10, 2024

Uh oh!

famfo commented Sep 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kleinesfilmroellchen left a comment

Choose a reason for hiding this comment

Uh oh!

stale Bot commented Nov 5, 2024

Uh oh!

famfo commented Nov 7, 2024

Uh oh!

stale Bot commented Dec 6, 2024

Uh oh!

stale Bot commented Jan 18, 2025

Uh oh!

stale Bot commented Jan 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

famfo Sep 10, 2024 •

edited

Loading