Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Assets for Sample Apps #445

Closed
wants to merge 2 commits into from

Conversation

hawkerm
Copy link
Sponsor Contributor

@hawkerm hawkerm commented Dec 3, 2022

Split off from #444

Description

Splits the initial commits from #444 of moving the assets to the shared project between the UWP and WinUI 3 sample apps.

(Also fixes the WinUI 3 taskbar title of the app in MainWindow.xaml.)

…mple App

Reduce duplication of image files and save space in repo (no functional change)
@Sergio0694 Sergio0694 added samples 📚 A change or improvement related to the samples refactoring 🧹 Code style and architecture improvements labels Dec 22, 2022
@Sergio0694
Copy link
Owner

Thank you! Two things:

  1. Could you drop the second commit?
  2. When opening this branch, I'm seeing this warning:

"The file '..\ComputeSharp.SwapChain\Textures\RustyMetal.png' could not be added to the project. '..\ComputeSharp.SwapChain\Textures\RustyMetal.png' is not an absolute path." [ComputeSharp.SwapChain.Uwp]

Is there a chance to fix this? Is this due to some content file being configured incorrectly?
It's not present in main, so it seems to be caused by the changes in this branch 🤔

Thank you!

@Sergio0694
Copy link
Owner

Closing this, same as #444 🙂

@Sergio0694 Sergio0694 closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🧹 Code style and architecture improvements samples 📚 A change or improvement related to the samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants