Draft: Remove all feature gates #27
Closed
ambaxter wants to merge 2 commits intoSergioBenitez:masterfrom
Closed
Conversation
Pear can be compiled on stable without it. Macro hygiene appears to be the last blocker. Signed-off-by: Adam Baxter <ambaxter@users.noreply.github.com>
11 tasks
|
@ambaxter this is panicking because you are actually using |
Owner
|
Thank you! Migrating the crate to stable is/was unfortunately more involved than this PR would allude. The efforts to migrate the crate were also already underway. I've pushed the completed migration at 333c9bf. Pear now compiles on stable! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a branch that requires no feature gates and compiles for the most part on beta.
The only remaining nightly-only functionality is Span.join which is nightly only: https://doc.rust-lang.org/proc_macro/struct.Span.html#method.join . Open issue is rust-lang/rust#54725
All macro compiles panic on https://github.com/SergioBenitez/Pear/blob/master/codegen/src/parser.rs#L168