Add DSD format support (DSF and DFF)#598
Conversation
M0Rf30
force-pushed
the
feat/dsd-support
branch
from
e1c9f4b to
e05788d
Compare
Serial-ATA
left a comment
Serial-ATA
left a comment
There was a problem hiding this comment.
Thanks for working on this! I haven't done a full review yet, but here's what I've gathered so far.
M0Rf30
force-pushed
the
feat/dsd-support
branch
from
e05788d to
644cca9
Compare
M0Rf30
changed the title
M0Rf30
force-pushed
the
feat/dsd-support
branch
from
644cca9 to
14afc2a
Compare
Serial-ATA
left a comment
Serial-ATA
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments so quickly! When I get a chance, I'll try this out with some real world assets. For now, mostly cleanup comments.
M0Rf30
force-pushed
the
feat/dsd-support
branch
3 times, most recently
from
694fafa to
7a78737
Compare
M0Rf30
force-pushed
the
feat/dsd-support
branch
2 times, most recently
from
19261f9 to
97201ff
Compare
M0Rf30
force-pushed
the
feat/dsd-support
branch
6 times, most recently
from
120fa5a to
3d0af5c
Compare
M0Rf30
force-pushed
the
feat/dsd-support
branch
from
5e7426a to
290efda
Compare
|
I think now everything should be ok |
M0Rf30
force-pushed
the
feat/dsd-support
branch
from
290efda to
c36472b
Compare
|
Any news on this? Don't want to put stress in any way 😄 . Is it fine or should I change something? |
Replace manual write_fn with internal_write_module annotation for both DFF and DSF formats. This auto-generates the write module and eliminates code duplication. - Rename write.rs to write_impl.rs to avoid module name conflicts - Remove redundant write_to and write_dff_file/write_dsf_file functions - Update all references to use write_impl module - Clean up unused imports
M0Rf30
force-pushed
the
feat/dsd-support
branch
from
c36472b to
7bd6ec9
Compare
|
@M0Rf30 I've updated the contributing guidelines to mention AI usage: https://github.com/Serial-ATA/lofty-rs/blob/main/CONTRIBUTING.md#note-on-ai This is a feature I'd really like to see, but I cannot go back and forth with an LLM in my reviews. Feel free to open another PR if you clean up the implementation in the future. |
2 participants
Adds read/write support for DSF and DFF audio formats.
DSF (DSD Stream File):
DFF (DSDIFF):
Supports DSD64 through DSD512 sample rates (2.8MHz - 22.5MHz).
Includes fuzz targets and test files.