feat: add DKIM support, fix bcc and cc, and add markdown support#17
Open
taciturnaxolotl wants to merge 10 commits intoSh4yy:mainfrom
Open
feat: add DKIM support, fix bcc and cc, and add markdown support#17taciturnaxolotl wants to merge 10 commits intoSh4yy:mainfrom
taciturnaxolotl wants to merge 10 commits intoSh4yy:mainfrom
Conversation
Author
|
I also fixed bcc and cc as they needed to be in the personalization object as shown here: https://api.mailchannels.net/tx/v1/documentation |
taciturnaxolotl
changed the title
Author
|
Just finished adding markdown support as well |
taciturnaxolotl
changed the title
This was referenced Apr 28, 2024
Open
|
Nice work @kcoderhtml ! I tried your code and it worked perfectly, I was able to set DKIM properly |
Author
|
I'm glad it worked for you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added DKIM support and made the error logging more effective by logging the error returned by mailchannels. BTW, this is a lifesaver for saving on time and effort writing my own worker; really appreciate all the hard work!
Closes: #8