fix(SteamDeck): add Steam Deck OLED limits #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastaq
reviewed
Mar 14, 2024
src/performance/gpu/amd/tdp.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn set_tdp(&mut self, value: f64) -> TDPResult<()> { | ||
| log::debug!("Setting TDP to: {}", value); | ||
| if value < 1.0 { | ||
| log::warn!("Cowardly refusing to set TDP less than 1W"); | ||
| return Err(TDPError::InvalidArgument(format!("Cowardly refusing to set TDP less than 1W: provided {}W", value))); | ||
| return Err(TDPError::InvalidArgument(format!( |
There was a problem hiding this comment.
Does the SteamOS kernel expose power1_cap_min and power1_cap_max in sysfs? Not blocking, something to look into as a way to auto detect limits.
pastaq
approved these changes
Mar 14, 2024
ShadowApex
force-pushed
the
shadowapex/deck-oled
branch
from
9196d45
to
e897e83
Compare
|
🎉 This PR is included in version 0.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.