Phase 7.2: KnowledgeService facade (#643)#656
Merged
Conversation
Phase 7.2: Create KnowledgeServiceImpl that wraps wiki_rag_service (search/retrieval) and knowledge domain services (collections, documents, FAQ) behind a single Protocol-conformant facade. - modules/knowledge/facade.py: KnowledgeServiceImpl + dict→TypedDict converters - Lazy wiki_rag access via ServiceContainer (handles late initialization) - Multi-collection search with dedup/merge - Registered in ServiceContainer.knowledge_service during startup - 18 unit tests (protocol compliance, signatures, converters) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shikhalev
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KnowledgeServiceImplinmodules/knowledge/facade.py— unified facade implementing theKnowledgeServiceProtocol frommodules/knowledge/protocols.pywiki_rag_service(search/retrieval) and domain services (FAQService,KnowledgeCollectionService,KnowledgeDocService) behind a single interfacewiki_rag_serviceviaServiceContainer— handles late initialization gracefully (returns empty results before RAG is ready)_to_search_result,_to_collection_info,_to_document_info,_to_faq_entry_info)ServiceContainer.knowledge_serviceduringinit_wiki_rag()startupknowledge_serviceset during startup for direct importsCloses #643
Files changed
modules/knowledge/facade.pyKnowledgeServiceImpl+ convertersmodules/knowledge/startup.pyinit_wiki_rag()app/dependencies.pyknowledge_servicefield toServiceContainerCLAUDE.mdtests/unit/test_knowledge_service.pyTest plan
🤖 Generated with Claude Code