Avoid duplicate code in users/profile, comments/course_group

ShanghaitechGeekPie · Apr 9, 2024 · 88ce7f3 · 88ce7f3
1 parent 5c18730
commit 88ce7f3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 21 deletions.
diff --git a/internal/controllers/comments/course_group.go b/internal/controllers/comments/course_group.go
@@ -43,16 +43,14 @@ func CourseGroupComment(c *fiber.Ctx) (err error) {
 	if err != nil {
 		return err
 	}
-	if currentUser.IsAdmin || currentUser.IsCommunityAdmin {
-		return c.Status(fiber.StatusOK).JSON(models.OKResponse{
-			Data:  response,
-			Error: false,
-		})
-	} else {
-		response.Reward = -1
-		return c.Status(fiber.StatusOK).JSON(models.OKResponse{
-			Data:  response,
-			Error: false,
-		})
+	if !currentUser.IsAdmin && !currentUser.IsCommunityAdmin {
+		for i := range response {
+			// 设置评论的 Reward 字段为 -1，表示不可见
+			response[i].Reward = -1
+		}
 	}
+	return c.Status(fiber.StatusOK).JSON(models.OKResponse{
+		Data:  response,
+		Error: false,
+	})
 }
diff --git a/internal/controllers/users/profile.go b/internal/controllers/users/profile.go
@@ -29,16 +29,11 @@ func Profile(c *fiber.Ctx) error {
 	if err != nil {
 		return err
 	}
-	if uid == id || currentUser.IsAdmin || currentUser.IsCommunityAdmin {
-		return c.Status(fiber.StatusOK).JSON(models.OKResponse{
-			Data:  response,
-			Error: false,
-		})
-	} else {
+	if !(uid == id || currentUser.IsAdmin || currentUser.IsCommunityAdmin) {
 		response.Reward = -1
-		return c.Status(fiber.StatusOK).JSON(models.OKResponse{
-			Data:  response,
-			Error: false,
-		})
 	}
+	return c.Status(fiber.StatusOK).JSON(models.OKResponse{
+		Data:  response,
+		Error: false,
+	})
 }