Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/226 - new attribute data-test #227

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oluizcarvalho
Copy link

resolve #226

Added a new attribute called dataTest, which adds a "data-test" attribute to menu links, making it easier to create automated tests.

no breaking changes

@oluizcarvalho
Copy link
Author

@ShankyTiwari can you have a look please?

@ShankyTiwari
Copy link
Owner

Hey Let me check this, Thank you for your contribution. Will revert back before this weekend!

@oluizcarvalho
Copy link
Author

Hey Let me check this, Thank you for your contribution. Will revert back before this weekend!

any feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data-test attribute to DOM
2 participants