Fixing SyncedFileSystemDirectoryFactory when the main index is corrupted #387
+409
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at stack traces reported from SyncedFileSystemDirectoryFactory shows that the errors always come from when the directory is first opened (i.e. site startup).
This adds an index checker and the ability to try to repair the index. The check will happen before the index is attempted to be open. If the check fails, it will try to fix it and report on the outcome. If a fix occurs, this generally means that documents may be lost, however, they might have been removed documents in the first place but the segments file wasn't updated during the syncing.
The index will then attempted to be read, if that fails, a new index will be created.