Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests re #2763 #2762 #2764

Closed
wants to merge 7 commits into from
Closed

fix tests re #2763 #2762 #2764

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d80dabe
fix(read): allow reading base64 files from a dataURI scheme
AbdelrahmanHafez Aug 8, 2022
f08cb11
fix: remove data URI scheme parameters before other text parsing
AbdelrahmanHafez Aug 8, 2022
c26f5a9
fix(read): mark media type as optional for base64 parsing
AbdelrahmanHafez Aug 8, 2022
7edc362
test(read): fix failing tests re #2762 #2763
AbdelrahmanHafez Aug 8, 2022
9d1b696
Merge branch 'master' into gh-2762
AbdelrahmanHafez Aug 8, 2022
19791ba
test: use assert.equal for backwards compatibility
AbdelrahmanHafez Aug 8, 2022
76a8635
Merge branch 'gh-2762' of https://github.com/AbdelrahmanHafez/sheetjs…
AbdelrahmanHafez Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,8 +698,14 @@ describe('input formats', function() {
var workBookFromRawBase64 = X.read(fileInBase64, { type: 'base64' });
var workBookFromBase64WithinDataURI = X.read(fileInBase64WithDataURIScheme, { type: 'base64' });

var jsonSheet1 = X.utils.sheet_to_json(workBookFromRawBase64.Sheets.Sheet1);
var jsonSheet2 = X.utils.sheet_to_json(workBookFromBase64WithinDataURI.Sheets.Sheet1);

// Assert
assert.deepStrictEqual(workBookFromRawBase64, workBookFromBase64WithinDataURI);
assert.equal(
JSON.stringify(jsonSheet1),
JSON.stringify(jsonSheet2)
);
});
it('handles base64 where data URI has no media type (gh-2762)', function() {
// Arrange
Expand All @@ -710,8 +716,14 @@ describe('input formats', function() {
var workBookFromRawBase64 = X.read(fileInBase64, { type: 'base64' });
var workBookFromBase64WithinDataURI = X.read(fileInBase64WithDataURIScheme, { type: 'base64' });

var jsonSheet1 = X.utils.sheet_to_json(workBookFromRawBase64.Sheets.Sheet1);
var jsonSheet2 = X.utils.sheet_to_json(workBookFromBase64WithinDataURI.Sheets.Sheet1);

// Assert
assert.deepStrictEqual(workBookFromRawBase64, workBookFromBase64WithinDataURI);
assert.equal(
JSON.stringify(jsonSheet1),
JSON.stringify(jsonSheet2)
);
});
if(typeof Uint8Array !== 'undefined') it('should read array', function() { artifax.forEach(function(p) {
X.read(fs.readFileSync(p, 'binary').split("").map(function(x) { return x.charCodeAt(0); }), {type:'array'});
Expand Down