Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: signing templates (continued) #719

Closed
wants to merge 369 commits into from
Closed

feat: signing templates (continued) #719

wants to merge 369 commits into from

Conversation

rajdip-b
Copy link
Contributor

@rajdip-b rajdip-b commented Feb 6, 2024

No description provided.

DonKoko and others added 26 commits February 6, 2024 10:27
@DonKoko
change healthcheck to query first user
e2d86e2
@hunar1312 @DonKoko
UI updates
6155692
@hunar1312 @DonKoko
fixes
041aeeb
@hunar1312 @DonKoko
update
142a978
@hunar1312 @DonKoko
UI updates
4d15740
@hunar1312 @DonKoko
UI updates
d3798fd
@DonKoko
mend
5f4ad4e
@DonKoko
some more minor adjustments
a426d18
@DonKoko
fix hono server, adjust some file locations
985ed30
@DonKoko
add a comment with some optimization ideas
4e8c411
@DonKoko
update with main and fix conflicts
77a2f9a
@DonKoko
Merge branch 'main' into hono-server
41ef831
@DonKoko
Merge pull request Shelf-nu#727 from Shelf-nu/free-trial-webhooks
6aacb1a 
Free trial webhooks
@DonKoko
Merge pull request Shelf-nu#728 from Shelf-nu/free-trial-webhooks
c95a815 
create customer on onboarding
@DonKoko
Merge pull request Shelf-nu#730 from Shelf-nu/free-trial-webhooks
7ba95b2 
implementing some small feedback
@DonKoko
Merge branch 'main' into hono-server
b33b3dd
@DonKoko
small adjustments and middleware cleanup
ff959ac
@DonKoko
mend
10a5f7d
@DonKoko
Changing some types and making minor adjustments
b7cac69
@DonKoko
fixed assets, started working on implementing auth
a601bf4
@DonKoko
fix basic login flow, adjust logger to make it log more details
9b3aa59
@DonKoko
re-enable pinno-pretty
33da4c5
@DonKoko
Merge branch 'main' into hono-server
6b94a23
@DonKoko
working on other routes
5221044
@DonKoko
solving some more public routes
42db930
@rajdip-b
Merge branch 'signing-templates' into signing-templates
df083d5
DonKoko and others added 11 commits March 6, 2024 16:40
@DonKoko
Merge pull request Shelf-nu#821 from rockingrohit9639/refactor/magic-…
46fef7e 
…link-auth

Refactor/magic link auth
@DonKoko
fixing responsiveness of some forms
16860c5
@DonKoko
Merge pull request Shelf-nu#826 from Shelf-nu/responsiveness-fixes
34717b2 
fixing responsiveness of some forms
@DonKoko
Merge branch 'main' into replace-magic-link-with-otp
246de21
@DonKoko
polishing
36589fe 
- removed oauth/callback route as its not needed anymore
- updated docs with info about OTP
- removed all mentions of magic links
@DonKoko
Merge pull request Shelf-nu#819 from Shelf-nu/replace-magic-link-with…
30f70cc 
…-otp

Replacing magic link with otp
@DonKoko
Update get-started.md
dc46ef2
@DonKoko
Merge pull request Shelf-nu#827 from Shelf-nu/DonKoko-patch-2
63a1015 
Update get-started.md
@DonKoko
updating csv parser
604b505 
- Detect encoding of the uploaded csv file
- Translate the encoding of the file to utf-8
@DonKoko
Merge pull request Shelf-nu#828 from Shelf-nu/814-bug-importing-csv-w…
8aa9e9c 
…ith-special-characters-breaks-in-the-ui

updating csv parser
@rajdip-b
Merge branch 'signing-templates' into signing-templates
1bedf51
DonKoko and others added 3 commits March 7, 2024 16:01
@DonKoko
fixing issue with escaped quotes and wrapping quotes in csv imports
a8b3c4c
@DonKoko
Merge pull request Shelf-nu#830 from Shelf-nu/813-bug-wrapping-quotes…
4ce99da 
…-are-not-removed-when-importing-csv

813 bug wrapping quotes are not removed when importing csv
@DonKoko
Save button improvements
d557fbf 
- Added save button in header and card on creating new asset
- Added save button in header when creating a new location
- Changed global size of buttons to sm from md
- Added add-another and cancel actions for location and asset form
- Created generic component for placing action buttons in header
- Created button-group component
- fixed breadcrumb of settings/team
- Changed size of per-page-select to make it consistent with new button sizes
@carlosvirreira
Copy link
Contributor

Excited to demo this! Thank you @rajdip-b

@rajdip-b
Copy link
Contributor Author

rajdip-b commented Mar 7, 2024

So many issues to fix! I'll try to finish this quick

@DonKoko
Copy link
Contributor

DonKoko commented Mar 21, 2024

hey @rajdip-b . I answered your comments in #618.
Also something very important. Yesterday we did a new release that changes how we handle responses and errors in shelf, that means you will have to adjust the functions and loaders/actions you did. Shouldn't be too much work, just implementing better error handling. The docs can be found here: https://github.com/Shelf-nu/shelf.nu/blob/main/docs/handling-errors.md

You can also look at the code to see other examples.

@rajdip-b rajdip-b closed this Apr 13, 2024
@rajdip-b rajdip-b deleted the signing-templates branch April 17, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajdip-b @carlosvirreira @DonKoko @hunar1312 @rockingrohit9639