Utilized-stake accounting invariants in mvp_staking_pool - #1465
Merged
Conversation
|
@0xNinx is attempting to deploy a commit to the pope-h's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@0xNinx Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- abuse.test.ts: 10 tests for abuse event retrieval with pagination and authorization - adminFraud.test.ts: 40 tests for fraud signal, assessment, hold, and threshold management - adminQuota.test.ts: 23 tests for quota usage, overrides, stats, and reset operations All tests follow established conventions covering success paths, authorization, validation failures, not-found/conflict paths, and response shape assertions.
- Created adminAuditLogs.test.ts with tests for audit log viewer endpoint - Created admin.test.ts with minimal authorization tests for admin endpoints - Both test files cover authorization rejection scenarios - All CI steps passing: npm ci, lint, test:ci, openapi:validate
Remove .unwrap() calls from methods that return unit type () instead of Result. - utilize_stake returns () - unstake returns () This fixes 7 compilation errors reported by cargo clippy.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly describe the change. This section is required for CI PR validation.
If this is a contract upgrade, include:
closes #1190
Linked issue (recommended)
Example:
Closes #123closes #1385
closes #1386
closes #1387
closes #1190
Changes
This section is required for CI PR validation.
Contract Upgrade Details (if applicable)
This section is required for CI PR validation if this is a contract upgrade.
Network
New Contract
C...sha256:...G...[link to transaction explorer]Upgrade Governance
Verification Steps
How to test
This section is required for CI PR validation.
Security Considerations
This section is required for CI PR validation.
Screenshots (if UI)
Include before/after screenshots for any UI changes. For new features, show different states (loading, error, success). For responsive changes, include mobile/tablet/desktop views.
Checklist
This section is required for CI PR validation.