Fix inconsistent type of readdir(plus) offsets#123
Open
progval wants to merge 1 commit intoSherlock-Holo:masterfrom
Open
Fix inconsistent type of readdir(plus) offsets#123progval wants to merge 1 commit intoSherlock-Holo:masterfrom
progval wants to merge 1 commit intoSherlock-Holo:masterfrom
Conversation
`u64` was used: * in `raw::abi::fuse_read_in` (the source of values for `readdir` and `readdirplus` arguments) * in `raw::abi::fuse_dirent` (what `DirectoryEntry` and `DirectoryEntryPlus` are converted to) * as `readdirplus` argument `i64` was used: * as `readdir` argument * in `raw::reply::DirectoryEntry` and `raw::reply::DirectoryEntryPlus`, This fixes this inconsistency by making them all use `u64`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
u64was used:raw::abi::fuse_read_in(the source of values forreaddirandreaddirplusarguments)raw::abi::fuse_dirent(whatDirectoryEntryandDirectoryEntryPlusare converted to)readdirplusargumenti64was used:readdirargumentraw::reply::DirectoryEntryandraw::reply::DirectoryEntryPlus,This fixes this inconsistency by making them all use
u64.