Feat 13/implement search in kbbi #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement new test scripts for context menu interaction and keyboard input simulation. - Update README.md with requirements for pyautogui usage in macOS. - Adjust Jest configuration in package.json to run tests in sequence with --runInBand flag.
…extension - Add 'contextMenus' permission and background script to manifest with 'service_worker' key. - Introduce background script to create a context menu item and handle its click event to open a new blank tab. - Set up TypeScript configuration to recognize Chrome types. - Modify webpack config to include the background script in the build process. - Refactor context menu test to include tests specific to the Chrome extension.
Update test cases in 'context-menu.test.ts' to reference the new script locations and adjust the keyboard interaction test to pass with any language input.
Also modify test regular expression to correctly match the URL format for KBBI searches.
Shiou-Ju
commented
Jan 10, 2024
- Renamed 'timeout' function to 'pause' for clearer intent. - Replaced direct `setTimeout` usage with the `pause` function for consistency and readability.
- Renamed function 'isTextSearchable' to 'isTextEncodable' in background.ts for better clarity. - Defined constants for URLs in context-menu.test.ts, improving maintainability and readability. - Updated test descriptions to more accurately reflect their purpose. - Replaced hardcoded strings with descriptive constants, enhancing code clarity. - Adjusted and clarified assertions in tests to better reflect the intention of the code. - Refactored URL checks in tests to use regex and constants for increased flexibility and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13