Fix #26 #27
Open
Fix #26 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shiou-Ju
reviewed
Mar 6, 2024
There was a problem hiding this comment.
shall be deleted and use yarn lock instead
There was a problem hiding this comment.
rm this file and rm rf node mudles , run yarn install to get new lock json
| } | ||
| browser = null; | ||
| // browser = null; |
There was a problem hiding this comment.
shall not be committed, this is for dev only
There was a problem hiding this comment.
delete this file as well as package-lock, run yarn again to make sure this requires being changed
There was a problem hiding this comment.
this binary is not necessary for all platform & why do we need to commit this
There was a problem hiding this comment.
these seems not necessary for changing
| @@ -41,5 +41,9 @@ | |||
| "typescript": "^5.3.3", | |||
| "webpack": "^5.89.0", | |||
| "webpack-cli": "^5.1.4" | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
why do we need these two ?
and if needed, shall we put here instead of devDependency?
Comment on lines
+148
to
154
| await rightClickOnElement(page, SELECTORS.EXPLANATION_SECTORS); // 可能有問題 | ||
| // console.log(__dirname) | ||
|
|
||
| await pause(1000); | ||
| // await execAsync(`python ${__dirname}/scripts/choose_copy_context_menu.py`); | ||
|
|
||
| const copiedText = await page.evaluate(() => navigator.clipboard.readText()); | ||
| // await pause(1000); | ||
|
|
|
|
||
| expect(copiedText.startsWith(prefix)).toBeFalsy(); | ||
| expect(copiedText).toMatch(TEXT_REGEX); | ||
| }, 10000); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the dist can't clean automatic problem.
By using rimraf replace rmdir.