Genie Configuration for Pythia8Decayer instead of deprecated Pythia6Decayer#1054
Merged
Genie Configuration for Pythia8Decayer instead of deprecated Pythia6Decayer#1054
Conversation
Contributor
|
apart from one comment, looks good to me, thanks! |
Contributor
Author
Thanks! |
Contributor
|
@eduard322 I also don't see your comment. Could you please let us know whether it's still applicable? |
Contributor
|
For the pre-commit failure, we should add "kno" to the ignored words either globally or for that file/those lines |
- Fix docstring example in makeGenieEvents.py (trailing backslash, .py extension) - Update Notes section to document new default GXMLPATH behaviour - Improve _build_env() to also check FAIRSHIP env var with clearer error - Clean up shipgen/genie_config/README.md formatting and typos - Add KNO to codespell ignore list to fix pre-commit failure
eduard322
previously approved these changes
Feb 26, 2026
olantwin
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all,
This follows ShipSoft/shipdist#181
I have copied all the XML files mentioned in GENIE-MC/Generator#430
I have created the genie_config folder in shipgen, just as sndsw does.
For now, the only thing we have different from the default tune is this change.
Best Regards,
Antonio
Checklist
The remaining CI fail is a false negative codespell check about "KNO" confused with the "KNOW" word, so I will mark it as pass anyway.