Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .Net 6 #36

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Support .Net 6 #36

wants to merge 11 commits into from

Conversation

PierreYvesR
Copy link

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (fake build or .\build.cmd) on local branch was successful
    build -t NuGet works

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Doesn't support .Net 6.

What is the new behavior?

Supports .Net 6

Does this introduce a breaking change?

  • Yes
  • No

Other information

kerams
kerams reviewed Jan 29, 2022
View reviewed changes
tests/Fable.SignalR.TestServer/SignalR.fs Outdated
@@ -1,6 +1,8 @@
namespace SignalRApp

#if !NET6_0
Copy link
Contributor

@kerams kerams Jan 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#if !NET6_0_OR_GREATER
The same problem in 2 other places.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Thanks

@kerams
Copy link
Contributor

kerams commented Feb 1, 2022

I think this should be changed to 2022. The 2019 image on Appveyor does not have .NET 6 and you'd need to install it manually.

Fable.SignalR/appveyor.yml

Line 3 in dab3b00

image: Visual Studio 2019

@kerams
Copy link
Contributor

kerams commented Feb 24, 2022 •
edited
Loading

Hello, @Shmew, are you around? This would be cool to have.

Trying to add Fable.SignalR.AspNetCore (when Giraffe 6 is also used) right now gives me

Paket may still find a valid resolution, but this might take a while.
  Conflict detected:
   - fable.signalr.aspnetcore 0.11.5 requested package System.Text.Encodings.Web: >= 5.0 < 6.0
   - System.Text.Json 6.0.0 requested package System.Text.Encodings.Web: >= 6.0

I actually wonder if it's really necessary to pin versions of those official .NET packages.

@PierreYvesR PierreYvesR marked this pull request as ready for review February 24, 2022 14:36
@tsujp
Copy link

tsujp commented May 9, 2022

@Shmew what's preventing this from being merged? Anything we can help with?

@rastreus rastreus mentioned this pull request May 9, 2022
Open
@Akash-Mair
Copy link

@PierreYvesR thanks for getting this across the line!

I noticed in the paket.dependencies the Net6 group both Saturn and Giraffe need to be updated to their latest versions, if you want them pinned they need to be updated to 0.16.1 and 6.0.0

ArtemyB and others added 8 commits January 19, 2023 12:46
@ArtemyB
Build-process and dependencies updates
0b29cec 
- Add Fable 4.0.0-theta-018 dotnet tool.
- Add separate Paket dependency groups for Fable demo and tests with Fable.Core 4.0.0-theta-007 and Fable.Elmish 4.
- Update Fable.SignalR.Tests to Elmish 4.
- Update SignalR NPM-package version range (for Femto).
- Update webpack.config.json and package.json (to use Fable 3+ as dotnet tool).
- Add Pnpm for JS package management (could be switched back to Yarn by a couple little build-script changes).
- gitignore and editorconfig updates.
@ArtemyB
feat(AspNetCore, Saturn): pass CancellationToken to server-streming f…
ec88462 
…unctions (`StreamFrom`).
@ArtemyB
feat(DotNet-client): pass CancellationToken to StreamFrom method.
1ed5b0a
@ArtemyB
fix: make FableHubModule.Stream.Both.Both constructor public (inste…
c6dc52c 
…ad of internal) -- to fix the hub registration error in DI-container; and some code reformatting.
@ArtemyB
build: bump version to 0.12.0-alpha.4
b7e0885
@ArtemyB
fix(AspNetCore): correct FableHub configuration in AddSignalR exten…
30f3e0d 
…sion method

Previously all the `OnConnected`, `OnDisconnected`, `Both` hubs have been registered as the `Both` hub specified in the wildcard-case in `Config` match.
@ArtemyB
build: bump version to 0.12.0-alpha.5, update release notes
e0dd941
@PierreYvesR
Merge pull request #1 from ArtemyB/net6
d21d30b 
Merging ArtemyB's changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerams kerams kerams left review comments

@Dewald844 Dewald844 Dewald844 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PierreYvesR @kerams @tsujp @Akash-Mair @Dewald844 @ArtemyB