Add onLinkClick global event (imperative api) #418
+121
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
force-pushed
the
fix.pd/add-on-link-click-global-event
branch
2 times, most recently
from
749e6f8 to
1e50cf3
Compare
Coverage Report
|
kieran-osgood-shopify
changed the title
| } | ||
|
|
||
| func checkoutDidClickLink(url: URL) { | ||
| if hasListeners { |
Contributor
Author
There was a problem hiding this comment.
use emit
kieran-osgood-shopify
force-pushed
the
fix.pd/add-on-link-click-global-event
branch
from
1e50cf3 to
37456c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Adds linkClick eventListener type for use in imperative api (
.present())PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.