-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensorEvent property to 'drag:stop' and 'drag:stopped' event #457
base: main
Are you sure you want to change the base?
Conversation
sourceContainer: this.sourceContainer, | ||
sensorEvent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the code here because drag:stopped
also needs this fix.
Thank you. @tsov This PR is ready to merge. |
When will this be available? It seems it has been ready for more than a year now |
And it has been another year, I still can't access the sensor event in drag:stop or sortable:sort. |
I forked this (non-public) and added the change myself, I can confirm that it works and that I can now access sensorEvent:
|
This PR implements or fixes:
Add
sensorEvent
property todrag:stop
anddrag:stopped
event, that was described in the documentation (extended fromDragEvent
) but was missing (undefined) ondrag:stop
anddrag:stopped
event.This PR closes the following issues
#324
Does this PR require the Docs to be updated?
No
Does this PR require new tests?
No. If we need a test to guarantee that all events have enough properties, we should include all events, not just
drag:stop
🤔This branch been tested on
Browsers: