Don't repeat global excludes in linter config #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused the config to keep growing which affected the file caching fingerprinting which relies on the config hash.
|
I have signed the CLA! |
|
Good find! What can we do to get this merged in so my caching works again? |
|
Just want to add, this fixes the issue I was seeing in #318. Let's get this merged in please. Thanks! |
|
Thanks! |
|
👏 👏 👏 Thank you @ianfleeton and @etiennebarrie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused the config to keep growing (and therefore modifying) which affected the file caching fingerprinting which relies on the config hash.
The
for_linterrequest for a config for the new ERBLint::Linters::NoUnusedDisable triggers this.This causes the caching feature to not actually work since 0.4.0.
Reported in issue #318