-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize repo name to erb_lint
#360
Merged
Merged
+93
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Jul 23, 2024
andyw8
reviewed
Jul 23, 2024
jenshenny
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks George!
gmcgibbon
reviewed
Jul 24, 2024
george-ma
force-pushed
the
gm/make-name-consistent
branch
from
July 25, 2024 19:22
642cce0
to
9b3b65b
Compare
jenshenny
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gmcgibbon
approved these changes
Aug 13, 2024
george-ma
force-pushed
the
gm/make-name-consistent
branch
from
September 6, 2024 01:08
e270e7d
to
bcb4cda
Compare
george-ma
force-pushed
the
gm/make-name-consistent
branch
from
September 6, 2024 01:12
bcb4cda
to
22a9a39
Compare
Please release a new version with this change, since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Someone pointed out that the
erb_lint
gem has inconsistent naming.erb-lint
https://github.com/Shopify/erb-linterb_lint
.erb-lint.yml
erblint
RubyGems will block anything less than 4 edits away to an existing gem over 10M downloads.
So even though this gem cannot be typosquatted due to RubyGems restrictions (eg. publishing a gem named
erb-lint
instead oferb_lint
), it'd be good to make changes to unify on a naming in the repo.What is this PR?
This PR aims to resolve the inconsistencies seen above and patches references to
erb-lint
in favor oferb_lint
. We're choosingerb_lint
as its the gem name (.gemspec
) which is the hardest to changeProposed Changes
.erb_lint.yml
or.erb-lint.yml
and warn that the latter will be going away soon and urge folks to rename their yaml file today. https://github.com/Shopify/erb-lint/blob/f82b3f7473dd1a0a966638c7f28b6ea213198b6a/lib/erb_lint/cli.rb#L16erb_lint
and whenerblint
is called, we could similarly warn about its usage and just call theerb_lint
one under the hood. https://github.com/Shopify/erb-lint/blob/main/exe/erblintNote: I did not change the name defined in
dev.yml
toerb_lint
because of:Next steps:
erb_lint
.