build static binaries (#579) #580
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, @robinelfrink ! thank you for your contribution. Can you sign the CLA here? https://cla.shopify.com/ |
No, I cannot. The form wants my home address. I don't see how that is relevant. |
|
I signed the CLA and submitted the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
goreleasebuild sstatic binaries, instead of dynamically linked. This ensures the binaries are useable on (almost) any version and variations of operating systems the binaries are built for, and also makes sure the docker container has a static binary.Fixes #579
Type of change
Checklist:
I will not sign the CLA, as it wants my home address, and I think that is completely irrelevant.
I hereby grant Shopify the right to simply copy the line I added to
.goreleaser.yml.