Fix error when parsing ERB files with yield on the top level #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top level yields are invalid Ruby on files, but are valid on `eval`. They exist on ERB files, and since those files are evaluated no written to disk they are fine. We can tell Prism to parse the code using the eval context by passing `scopes: [[]]` to `parse`, but since are are using the `Prism::Translation::Parser` class we have no way to do that. A [PR][1] was proposed to Prism to always consider the code as being evaluated in the `Parser` translation. For now, we can safely ignore that class of error by overriding the `valid_error?` method on our own parser. Fixes #400. [1]: ruby/prism#2741
gmcgibbon
approved these changes
May 2, 2024
|
We might need multiple gemfiles. |
|
I'm dropping support to EOL rubies. |
We are going to drop support to 2.7, but don't want to do before a new release with #404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top level yields are invalid Ruby on files, but are valid on
eval.They exist on ERB files, and since those files are evaluated no written to disk they are fine.
We can tell Prism to parse the code using the eval context by passing
scopes: [[]]toparse, but since are are using thePrism::Translation::Parserclass we have no way to do that.A PR was proposed to Prism to always consider the code as being evaluated in the
Parsertranslation.For now, we can safely ignore that class of error by overriding the
valid_error?method on our own parser.Fixes #400.