Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Ruby definitions #407

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Remove unnecessary Ruby definitions #407

merged 3 commits into from
Jul 3, 2024

Conversation

jenshenny
Copy link
Contributor

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR removes all other references to Ruby as the tools will read from .ruby-version.

What approach did you choose and why?

  • Removed Ruby version in dev.yml as dev reads from .ruby-version
  • Upgraded Rubocop to 1.61+ as the TargetRubyVersion will start reading from the required_ruby_version from the gemspec
  • Remove ruby version from lint and typechecking, GH actions will use the Ruby version in .ruby-version.
    • Reintroduced the bundler cache option and removed the manual install of gems for typechecking. This is done by ignoring vendored gems from the sorbet config as what sorbet does now. sorbet/sorbet@cfc7c37

Type of Change

  • Bugfix
  • New feature
  • Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

  • Breaking change (fix or feature that would cause existing functionality to change)

Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.

If no additional notes are necessary, delete this section or leave it unchanged.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • It is safe to rollback this change.

dev reads from .ruby-version
will read from required_ruby_version in gemspec
Github Actions defaults to .ruby-version

Also reintroducing the bundler cache, and ignore vendored gems from typecheck
as it was causing typecheck to fail instead of bundle installing manually
@jenshenny jenshenny marked this pull request as ready for review June 20, 2024 01:51
@jenshenny jenshenny requested a review from a team as a code owner June 20, 2024 01:51
Base automatically changed from drop-old-ruby to main July 3, 2024 18:49
@jenshenny jenshenny merged commit fec2fbf into main Jul 3, 2024
9 checks passed
@jenshenny jenshenny deleted the centralize-ruby branch July 3, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants