Skip to content

Conversation

@mpshopify
Copy link
Contributor

WHY are these changes introduced?

Stars and text on interstitial modal used theme-aware CSS colors, resulting in incorrect rendering on dark mode. It was also possible to horizontal scroll on the modal

WHAT is this pull request doing?

Replaces theme-aware CSS colors with hardcoded colors for the interstitial modal only. Prevents horizontal scroll on interstitial modal.

@mpshopify mpshopify requested a review from Aubron November 3, 2025 15:20
@shopify-shipitnext
Copy link

🔎 View this PR in Shipit Next.

ℹ️ Expand to learn how to deploy and handle emergencies using Shipit Next

Overview

Shipit Next will merge your code on your behalf because this repository uses Shipit Next and its merge queue.

To ship this PR, you can either:

Comment Commands

  • /shipit: Enqueue this PR into the merge queue where it will eventually be merged and deployed.
  • /cancel: Eject this PR from the merge queue and rebuild PRs that were enqueued after this PR.
  • /shipit --jump-queue: Enqueue this PR at the top of the merge queue where it will be included in the next deploy. Use this for non-emergency situations.
    - Emergency handling procedure for this command can be found here.
  • /shipit --emergency: Merge this PR directly into main and deploy to all environments once all require_for_emergency CI checks pass. Please be aware that changes deployed with this command will not be automatically rolled back.

Commands exclusive to Deploy Before Merge

  • /cancel --emergency: Eject this PR from the merge and rollback any deployments containing this PR.

Documentation

Questions or feedback?

@mpshopify mpshopify closed this Nov 3, 2025
@mpshopify mpshopify deleted the polaris-react-deprecation branch November 3, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant