Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default series icon shape to circle #1798

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

envex
Copy link
Collaborator

@envex envex commented Feb 3, 2025

What does this implement/fix?

As part of https://github.com/Shopify/analytics-ui-components/pull/322 we want to change the default series icon to a circle instead of a rounded square.

Figma

What do the changes look like?

image

Storybook link

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

Copy link

github-actions bot commented Feb 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.75 KB (0%) 1.3 s (0%) 1.2 s (+8.15% 🔺) 2.4 s
polaris-viz-cjs 230.46 KB (+0.06% 🔺) 4.7 s (+0.06% 🔺) 2.3 s (+20.41% 🔺) 6.9 s
polaris-viz-esm 186.33 KB (+0.03% 🔺) 3.8 s (+0.03% 🔺) 1.9 s (+32.07% 🔺) 5.6 s
polaris-viz-css 5.86 KB (+0.37% 🔺) 118 ms (+0.37% 🔺) 488 ms (+24.82% 🔺) 606 ms
polaris-viz-esnext 193.62 KB (+0.04% 🔺) 3.9 s (+0.04% 🔺) 1.3 s (+6% 🔺) 5.2 s

@envex envex force-pushed the envex/default-series branch 3 times, most recently from c6c4ebc to eb05fce Compare February 4, 2025 15:09
Copy link
Collaborator

@michaelnesen michaelnesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@envex envex force-pushed the envex/default-series branch from eb05fce to 64781ef Compare February 5, 2025 15:45
@envex envex merged commit 97489c6 into main Feb 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants