WIP: Simplify Tooltips #1799
Draft
WIP: Simplify Tooltips #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envex
force-pushed
the
envex/better-tooltip-positioning
branch
4 times, most recently
from
da1eac7 to
76fa457
Compare
envex
force-pushed
the
envex/better-tooltip-positioning
branch
from
76fa457 to
470a485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
See if we can move away from positioning the tooltip based a bunch of math around the data and SVG points.
I think we should be able to use data attributes to get all the data we need to render and position the tooltips. We already have it available when we render the chart elements, why not just use that and skip all the
getXPositionandgetAlteredXfunctions we have for each chart.This should make adding tooltips to new charts way easier.
Does this close any currently open issues?
What do the changes look like?
Storybook link
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package