Skip to content

Commit

Permalink
[Autocomplete] Consolidate se23 styles (#10007)
Browse files Browse the repository at this point in the history
### WHY are these changes introduced?

Resolves #9917 .

### WHAT is this pull request doing?

Consolidates se23 beta styles for `Autocomplete`.

### How to 🎩


[Storybook](https://5d559397bae39100201eedc1-ztmfqwvbxv.chromatic.com/?path=/story/all-components-autocomplete--with-action)

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [x] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [x] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
  • Loading branch information
laurkim authored and sam-b-rose committed Aug 15, 2023
1 parent 241e146 commit 5f72c8f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 28 deletions.
2 changes: 1 addition & 1 deletion .changeset/tall-chicken-repeat.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'@shopify/polaris': major
---

Removed Summer Editions experimental styles and code for the following components: `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`
Removed Summer Editions experimental styles and code for the following components: `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`, `Autocomplete`
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,7 @@
.Action {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
svg {
fill: var(--p-color-icon-interactive);
}

#{$se23} & {
// stylelint-disable-next-line -- se23 overrides
svg {
fill: var(--p-color-icon);
}
fill: var(--p-color-icon);
}

&.destructive {
Expand All @@ -48,15 +41,8 @@
padding: var(--pc-mapped-actions-item-vertical-padding) var(--p-space-2);
// stylelint-disable-next-line -- using pre-existing private pc token
margin: calc(-1 * var(--pc-mapped-actions-item-vertical-padding))
calc(-1 * var(--p-space-2));
border-radius: var(--p-border-radius-1);

#{$se23} & {
border-radius: var(--p-border-radius-2);
// stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list -- se23 overrides
margin: calc(-1 * var(--pc-mapped-actions-item-vertical-padding))
calc(-1 * var(--p-space-3));
}
calc(-1 * var(--p-space-3));
border-radius: var(--p-border-radius-2);

&:hover {
background-color: var(--p-color-bg-hover);
Expand Down Expand Up @@ -95,13 +81,6 @@
fill: var(--p-color-icon-critical);
}

#{$se23} & {
// stylelint-disable-next-line selector-max-combinators -- se23 overrides
svg {
fill: var(--p-color-icon-critical);
}
}

&:hover {
background-color: var(--p-color-bg-critical-subdued-hover);
}
Expand Down Expand Up @@ -146,9 +125,7 @@
// stylelint-disable -- generated by polaris-migrator DO NOT COPY
margin: calc(-0.5 * var(--pc-mapped-actions-image-size)) var(--p-space-4)
calc(-0.5 * var(--pc-mapped-actions-image-size)) 0;
#{$se23} & {
margin-right: var(--p-space-2);
}
margin-right: var(--p-space-2);
// stylelint-enable
background-size: cover;
background-position: center center;
Expand Down

0 comments on commit 5f72c8f

Please sign in to comment.