moved back to border 0

Shopify · Mar 13, 2024 · 93b1513 · 93b1513
1 parent 89bcfee
commit 93b1513
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/polaris-react/src/components/IndexTable/IndexTable.module.scss b/polaris-react/src/components/IndexTable/IndexTable.module.scss
@@ -147,10 +147,7 @@ $loading-panel-height: 53px;
 }
 
 .TableRow {
-  // stylelint-disable-next-line -- polaris/conventions/polaris/custom-property-allowed-list -- row background color
-  --pc-row-background-color: var(--p-color-bg-surface);
-  /* stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list  -- adds row background color */
-  background-color: var(--pc-row-background-color);
+  background-color: var(--p-color-bg-surface);
   cursor: pointer;
   border-top: var(--p-border-width-025) solid var(--p-color-border-secondary);
 
@@ -163,8 +160,7 @@ $loading-panel-height: 53px;
   }
 
   &.TableRow-borderless {
-    /* stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list -- makes row border ivisible*/
-    border-color: var(--pc-row-background-color);
+    border: 0;
   }
 
   &.toneSuccess {
@@ -257,8 +253,6 @@ $loading-panel-height: 53px;
   }
 
   &.TableRow-subheader {
-    // stylelint-disable-next-line -- polaris/conventions/polaris/custom-property-allowed-list  -- subheader row background color
-    --pc-row-subheader-background-color: var(--p-color-bg-surface-secondary);
     cursor: default;
     // stylelint-disable-next-line selector-max-combinators, selector-max-class, selector-max-specificity -- generated by polaris-migrator DO NOT COPY
     &,
@@ -269,14 +263,23 @@ $loading-panel-height: 53px;
       color: var(--p-color-text-secondary);
       font-weight: var(--p-font-weight-medium);
       font-size: var(--p-font-size-300);
-      /* stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list -- adds subheader row background color */
-      background-color: var(--pc-row-subheader-background-color);
+      background-color: var(--p-color-bg-surface-secondary);
+      border-top: var(--p-border-width-025) solid var(--p-color-border);
+      border-bottom: var(--p-border-width-025) solid var(--p-color-border);
+      border-color: var(--p-color-border);
     }
 
     // stylelint-disable-next-line selector-max-class -- makes subheader borders not visible
     &.TableRow-borderless {
-      /* stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list -- makes subheader row borders not visible */
-      border-color: var(--pc-row-subheader-background-color);
+      border: 0;
+      // stylelint-disable-next-line selector-max-combinators, selector-max-class, selector-max-specificity --  makes subheader borders not visible
+      &,
+      .TableCell:first-child,
+      .TableCell-first,
+      .TableCell-first + .TableCell,
+      .TableCell:last-child {
+        border: 0;
+      }
     }
   }