[EmptyState] Manually set height

Shopify · Mar 29, 2024 · afc2eb1 · afc2eb1
1 parent 2d121d1
commit afc2eb1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/polaris-react/src/components/EmptyState/EmptyState.module.css b/polaris-react/src/components/EmptyState/EmptyState.module.css
@@ -1,3 +1,7 @@
+.Image {
+  height: 226px;
+}
+
 .imageContained {
   @media (--p-breakpoints-md-up) {
     position: initial;

diff --git a/polaris-react/src/components/EmptyState/EmptyState.tsx b/polaris-react/src/components/EmptyState/EmptyState.tsx
@@ -1,4 +1,4 @@
-import React, {useState, useEffect} from 'react';
+import React from 'react';
 
 import {classNames} from '../../utilities/css';
 import type {ComplexAction} from '../../types';
@@ -46,19 +46,8 @@ export function EmptyState({
   secondaryAction,
   footerContent,
 }: EmptyStateProps) {
-  const [imageLoaded, setImageLoaded] = useState<boolean>(false);
-
-  useEffect(() => {
-    const img: HTMLImageElement = new window.Image(0, 0);
-    img.src = largeImage || image;
-    img.onload = () => {
-      setImageLoaded(true);
-    };
-  }, [largeImage, image]);
-
-  if (!imageLoaded) return null;
-
   const imageContainedClass = classNames(
+    styles.Image,
     imageContained && styles.imageContained,
   );