Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common actions] Update Button storybook examples to use PlusCircleIcon #11795

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

aaronccasanova
Copy link
Member

WHY are these changes introduced?

Closes https://github.com/Shopify/polaris-internal/issues/1518

WHAT is this pull request doing?

This PR updates the Button storybook examples to follow the Common Actions guidance.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@aaronccasanova aaronccasanova added 🤖Skip Changelog Causes CI to ignore changelog update check. #gsd:38421 Polaris Common Action Patterns labels Mar 27, 2024
@aaronccasanova aaronccasanova self-assigned this Mar 27, 2024
@aaronccasanova
Copy link
Member Author

/snapit

Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@aaronccasanova aaronccasanova merged commit eda60b0 into main Mar 28, 2024
20 checks passed
@aaronccasanova aaronccasanova deleted the update-button-plus-icons branch March 28, 2024 15:37
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:38421 Polaris Common Action Patterns 🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants