Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Common actions] Update Button storybook examples to use PlusCircleIcon #11795

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[Common actions] Update Button storybook examples to use PlusCircleIcon #11795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions polaris-react/src/components/Button/Button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
} from '@shopify/polaris';
import {
PlusIcon,
PlusCircleIcon,
XSmallIcon,
ChevronDownIcon,
EditIcon,
Expand Down Expand Up @@ -211,10 +212,10 @@ export function Plain() {
<Button variant="plain" disabled>
Label
</Button>
<Button variant="plain" icon={PlusIcon}>
<Button variant="plain" icon={PlusCircleIcon}>
Label
</Button>
<Button variant="plain" disabled icon={PlusIcon}>
<Button variant="plain" disabled icon={PlusCircleIcon}>
Label
</Button>
<Button variant="plain" disclosure>
Expand Down Expand Up @@ -246,10 +247,10 @@ export function MonochromePlain() {
<Box padding="400">
<InlineStack gap="400" blockAlign="center">
<Button variant="monochromePlain">Default</Button>
<Button variant="monochromePlain" icon={PlusIcon}>
<Button variant="monochromePlain" icon={PlusCircleIcon}>
With icon
</Button>
<Button variant="monochromePlain" disabled icon={PlusIcon}>
<Button variant="monochromePlain" disabled icon={PlusCircleIcon}>
Disabled with icon
</Button>
<Button variant="monochromePlain" disclosure>
Expand Down Expand Up @@ -281,10 +282,10 @@ export function Tertiary() {
<Button variant="tertiary" disabled>
Label
</Button>
<Button variant="tertiary" icon={PlusIcon}>
<Button variant="tertiary" icon={PlusCircleIcon}>
Label
</Button>
<Button variant="tertiary" disabled icon={PlusIcon}>
<Button variant="tertiary" disabled icon={PlusCircleIcon}>
Label
</Button>
<Button variant="tertiary" disclosure>
Expand All @@ -311,10 +312,10 @@ export function Tertiary() {
<Button variant="tertiary" disabled>
Label
</Button>
<Button variant="tertiary" icon={PlusIcon}>
<Button variant="tertiary" icon={PlusCircleIcon}>
Label
</Button>
<Button variant="tertiary" disabled icon={PlusIcon}>
<Button variant="tertiary" disabled icon={PlusCircleIcon}>
Label
</Button>
<Button variant="tertiary" disclosure>
Expand Down
Loading