Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Badge] Consolidate se23 logic and styles #9918

Closed
Tracked by #9913
sophschneider opened this issue Aug 9, 2023 · 0 comments
Closed
Tracked by #9913

[Badge] Consolidate se23 logic and styles #9918

sophschneider opened this issue Aug 9, 2023 · 0 comments
Assignees

Comments

@sophschneider
Copy link
Contributor

No description provided.

@sophschneider sophschneider self-assigned this Aug 10, 2023
sophschneider added a commit that referenced this issue Aug 11, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sophschneider added a commit that referenced this issue Aug 15, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose pushed a commit that referenced this issue Aug 15, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose pushed a commit that referenced this issue Aug 15, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose pushed a commit that referenced this issue Aug 15, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose pushed a commit that referenced this issue Aug 15, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose pushed a commit that referenced this issue Aug 15, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
kyledurand pushed a commit that referenced this issue Aug 16, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
kyledurand pushed a commit that referenced this issue Aug 17, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sophschneider added a commit that referenced this issue Sep 19, 2023
### WHY are these changes introduced?

Fixes #9918

### WHAT is this pull request doing?

Removing flagged se23 code from badge

### How to 🎩

Compare and make sure they are the same:

* This PR's
[Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false)
* [Production
Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant