[Badge] Consolidate se23 logic and styles #10004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accepted the known issue popover UI tests |
laurkim
reviewed
Aug 11, 2023
| } | ||
| } | ||
|
|
||
| @mixin statusSuccess-strong { | ||
| .statusSuccess-strong-experimental { |
There was a problem hiding this comment.
Not blocking for merge but should we also remove -experimental from the classname?
There was a problem hiding this comment.
I'm going to leave this as is for now, it is using the prop variation to get the class name and we aren't cleaning up the props just yet
laurkim
approved these changes
Aug 11, 2023
sophschneider
force-pushed
the
sophie/badge-cleanup
branch
from
d563e34
to
6f4775a
Compare
sophschneider
added
the
🤖Skip Changelog
sophschneider
force-pushed
the
sophie/badge-cleanup
branch
from
6f4775a
to
fce361f
Compare
sophschneider
added a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
kyledurand
pushed a commit
that referenced
this pull request
Aug 16, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
kyledurand
pushed a commit
that referenced
this pull request
Aug 17, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
sophschneider
added a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Fixes #9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#9918 ### WHAT is this pull request doing? Removing flagged se23 code from badge ### How to 🎩 Compare and make sure they are the same: * This PR's [Storybook](https://5d559397bae39100201eedc1-fqebvmxjcw.chromatic.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:false) * [Production Storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-badge--all&globals=polarisSummerEditions2023:true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #9918
WHAT is this pull request doing?
Removing flagged se23 code from badge
How to 🎩
Compare and make sure they are the same: