Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Consolidate se23 styles #10007

Merged
merged 2 commits into from
Aug 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/tall-chicken-repeat.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
'@shopify/polaris': major
---

Removed Summer Editions experimental styles and code for the following components: `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`
Removed Summer Editions experimental styles and code for the following components: `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`, `Autocomplete`
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,7 @@
.Action {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
svg {
fill: var(--p-color-icon-interactive);
}

#{$se23} & {
// stylelint-disable-next-line -- se23 overrides
svg {
fill: var(--p-color-icon);
}
fill: var(--p-color-icon);
}

&.destructive {
Expand All @@ -48,15 +41,8 @@
padding: var(--pc-mapped-actions-item-vertical-padding) var(--p-space-2);
// stylelint-disable-next-line -- using pre-existing private pc token
margin: calc(-1 * var(--pc-mapped-actions-item-vertical-padding))
calc(-1 * var(--p-space-2));
border-radius: var(--p-border-radius-1);

#{$se23} & {
border-radius: var(--p-border-radius-2);
// stylelint-disable-next-line polaris/conventions/polaris/custom-property-allowed-list -- se23 overrides
margin: calc(-1 * var(--pc-mapped-actions-item-vertical-padding))
calc(-1 * var(--p-space-3));
}
calc(-1 * var(--p-space-3));
border-radius: var(--p-border-radius-2);

&:hover {
background-color: var(--p-color-bg-hover);
Expand Down Expand Up @@ -95,13 +81,6 @@
fill: var(--p-color-icon-critical);
}

#{$se23} & {
// stylelint-disable-next-line selector-max-combinators -- se23 overrides
svg {
fill: var(--p-color-icon-critical);
}
}

&:hover {
background-color: var(--p-color-bg-critical-subdued-hover);
}
Expand Down Expand Up @@ -146,9 +125,7 @@
// stylelint-disable -- generated by polaris-migrator DO NOT COPY
margin: calc(-0.5 * var(--pc-mapped-actions-image-size)) var(--p-space-4)
calc(-0.5 * var(--pc-mapped-actions-image-size)) 0;
#{$se23} & {
margin-right: var(--p-space-2);
}
margin-right: var(--p-space-2);
// stylelint-enable
background-size: cover;
background-position: center center;
Expand Down