Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nav level rule #10568

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Remove nav level rule #10568

merged 1 commit into from
Sep 19, 2023

Conversation

sam-b-rose
Copy link
Member

@sam-b-rose sam-b-rose commented Sep 19, 2023

Remove the max level rule in the Frame nav and use the hideChildren boolean in frontmatter

@@ -8,6 +8,13 @@
"rollupButton": "View actions"
}
},
"ActionList": {
"SearchField": {
"clearButtonLabel": "Clear",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Clear for key Polaris.ActionList.SearchField.clearButtonLabel is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

"ActionList": {
"SearchField": {
"clearButtonLabel": "Clear",
"search": "Search",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Search for key Polaris.ActionList.SearchField.search is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

"SearchField": {
"clearButtonLabel": "Clear",
"search": "Search",
"placeholder": "Search actions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Search actions for key Polaris.ActionList.SearchField.placeholder is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@sam-b-rose sam-b-rose changed the base branch from main to next September 19, 2023 16:23
@sam-b-rose sam-b-rose merged commit 4aee4f5 into next Sep 19, 2023
2 checks passed
@sam-b-rose sam-b-rose deleted the fix-nav-and-subnav branch September 19, 2023 16:23
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
Remove the max level rule in the Frame nav and use the `hideChildren`
boolean in frontmatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant