[Page -> Header] Ensure we only set min-width on title when title is not long #11504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @mrcthms! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
kyledurand
approved these changes
Jan 25, 2024
.changeset/fast-shrimps-bow.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@shopify/polaris': minor | |||
There was a problem hiding this comment.
This would be a patch fix I think
Merged
chloerice
pushed a commit
that referenced
this pull request
Jan 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#11478](#11478) [`b786bb93c`](b786bb9) Thanks [@Rusty-UX](https://github.com/Rusty-UX)! - Added DatabaseConnectIcon ## @shopify/[email protected] ### Minor Changes - [#11474](#11474) [`26b3afb3d`](26b3afb) Thanks [@mrcthms](https://github.com/mrcthms)! - [BulkActions and SelectAllActions] Ensure backwards compatibilility after prop reorganisation between components - [#11497](#11497) [`d50cc6d91`](d50cc6d) Thanks [@mrcthms](https://github.com/mrcthms)! - Improved test reliability for non-rolled up actions in `ActionMenu` - [#10981](#10981) [`2dcc73f1a`](2dcc73f) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated the sticky behaviour of BulkActions, SelectAllActions, and Pagination for our tables and lists - [#11441](#11441) [`74174b6c1`](74174b6) Thanks [@mrcthms](https://github.com/mrcthms)! - Improved the logic of action rollup and calculation of available space in `ActionMenu` and `Tabs` - [#11491](#11491) [`ac004fc97`](ac004fc) Thanks [@lgriffee](https://github.com/lgriffee)! - [`Button`] Remove underline from `monochromePlain` default state - [#11486](#11486) [`02a6d9b18`](02a6d9b) Thanks [@translation-platform](https://github.com/apps/translation-platform)! - Updated translations for SearchField suffix within IndexFilters - [#11344](#11344) [`c9abd3c0c`](c9abd3c) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added Polaris Tokens for Mobile typography - [#11412](#11412) [`f1b44ab57`](f1b44ab) Thanks [@mrcthms](https://github.com/mrcthms)! - [TextField] Updated the TextField with new `autoSize` and `loading` props - [#11431](#11431) [`f9b9fa4e8`](f9b9fa4) Thanks [@lone-star](https://github.com/lone-star)! - Added `tone`, `icon`, and `onClick` props to `Toast` ### Patch Changes - [#11464](#11464) [`2ee7dbd30`](2ee7dbd) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Updated `Button` shadow tokens and replaced hardcoded box-shadow values - [#11504](#11504) [`1910c6975`](1910c69) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated Page Header to only ensure no wrapping of the title when the title is relatively short - [#11473](#11473) [`6579537e4`](6579537) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Fixed focus ring size for plain and plain monochrome Button variants - [#11487](#11487) [`4aabf7c1a`](4aabf7c) Thanks [@yurm04](https://github.com/yurm04)! - [Modal] Fixed Footer position to bottom of container - [#11466](#11466) [`1953b6935`](1953b69) Thanks [@mrcthms](https://github.com/mrcthms)! - [TextField] Fixed positional issue of loading indicator when no clear button is present - [#11462](#11462) [`2febd60f1`](2febd60) Thanks [@sophschneider](https://github.com/sophschneider)! - Lowered the z-index of `Filter`s container to be below `Card` shadow bevel - [#11467](#11467) [`75cbcd70b`](75cbcd7) Thanks [@kyledurand](https://github.com/kyledurand)! - Increased contrast on Tooltip underline - [#11482](#11482) [`59371946c`](5937194) Thanks [@translation-platform](https://github.com/apps/translation-platform)! - [SearchField] Updated translation - Updated dependencies \[[`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c), [`b786bb93c`](b786bb9)]: - @shopify/[email protected] - @shopify/[email protected] ## @shopify/[email protected] ### Minor Changes - [#11344](#11344) [`c9abd3c0c`](c9abd3c) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added Polaris Tokens for Mobile typography ### Patch Changes - [#11464](#11464) [`2ee7dbd30`](2ee7dbd) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Updated `Button` shadow tokens and replaced hardcoded box-shadow values ## @shopify/[email protected] ### Minor Changes - [#11344](#11344) [`c9abd3c0c`](c9abd3c) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `typography` `declaration-property-value-disallowed-list` to support Polaris Tokens `text` variants ### Patch Changes - Updated dependencies \[[`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`c9abd3c0c`](c9abd3c), [`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c)]: - @shopify/[email protected] - @shopify/[email protected] ## [email protected] ### Minor Changes - [#11506](#11506) [`c19b0f638`](c19b0f6) Thanks [@lgriffee](https://github.com/lgriffee)! - Added ability to mark prop values as deprecated ### Patch Changes - [#11457](#11457) [`966d1901e`](966d190) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Added fallback to no active icon on Icons page when not a valid icon name is used in the search param - [#11466](#11466) [`1953b6935`](1953b69) Thanks [@mrcthms](https://github.com/mrcthms)! - [TextField] Fixed positional issue of loading indicator when no clear button is present - [#11461](#11461) [`d26df7eb0`](d26df7e) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Added deprecation warning to old icon names informing users to use the new icon name - [#11467](#11467) [`75cbcd70b`](75cbcd7) Thanks [@kyledurand](https://github.com/kyledurand)! - Increased contrast on Tooltip underline - Updated dependencies \[[`26b3afb3d`](26b3afb), [`2ee7dbd30`](2ee7dbd), [`1910c6975`](1910c69), [`d50cc6d91`](d50cc6d), [`6579537e4`](6579537), [`2dcc73f1a`](2dcc73f), [`74174b6c1`](74174b6), [`4aabf7c1a`](4aabf7c), [`ac004fc97`](ac004fc), [`1953b6935`](1953b69), [`02a6d9b18`](02a6d9b), [`c9abd3c0c`](c9abd3c), [`2febd60f1`](2febd60), [`b786bb93c`](b786bb9), [`75cbcd70b`](75cbcd7), [`f1b44ab57`](f1b44ab), [`f9b9fa4e8`](f9b9fa4), [`59371946c`](5937194)]: - @shopify/[email protected] - @shopify/[email protected] - @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`2ee7dbd30`](2ee7dbd), [`c9abd3c0c`](c9abd3c)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…not long (Shopify#11504) ### WHY are these changes introduced? To prevent wrapping of titles prematurely, we included some CSS to ensure that the width of the Title element within the Page Header would always be at-minimum the width of its content. This causes issues when titles are long, as it can cause the layout of the rest of the header to go outside of the page. This PR ensures that we only use `min-width: fit-content` if we detect the title is not long and we can safely ensure it stays on a single line. For titles that are longer, they now wrap as before, to give space for the actions within the Header. ### Examples <img width="1588" alt="Screenshot 2024-01-25 at 16 21 43" src="https://github.com/Shopify/polaris/assets/2562596/a2f6e2b4-9df4-4a62-9b53-b643403061b1"> <img width="1588" alt="Screenshot 2024-01-25 at 16 21 36" src="https://github.com/Shopify/polaris/assets/2562596/3fae343e-eeb4-4892-8206-260813acbfb1"> <img width="1588" alt="Screenshot 2024-01-25 at 16 21 32" src="https://github.com/Shopify/polaris/assets/2562596/4fd6d4aa-d0cc-4f22-877b-608278d414c9"> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To prevent wrapping of titles prematurely, we included some CSS to ensure that the width of the Title element within the Page Header would always be at-minimum the width of its content. This causes issues when titles are long, as it can cause the layout of the rest of the header to go outside of the page.
This PR ensures that we only use
min-width: fit-contentif we detect the title is not long and we can safely ensure it stays on a single line. For titles that are longer, they now wrap as before, to give space for the actions within the Header.Examples
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes