Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v14.0.0 #11573

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

v14.0.0 #11573

wants to merge 10 commits into from

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Feb 8, 2024 •
edited by lgriffee
Loading

  • Remove Data URL and placeholder support from the Icon component #11276 (@aaronccasanova)
    • Ensure this change is documented in the major version guide
    • Ensure this change has any migrations needed
  • [Icon] Remove text tones and update  #11356 (@yurm04)
    • Ensure this change is documented in the major version guide
    • Ensure this change has any migrations needed

    We need to create a migration to find <Icon> components that use text color and change their code so that they use <Icon tone="inherit"> and if they do not have a parent <Text> with the same tone color one will need to be added around it.

  • Removed SidekickIcon
  • Updated minimum NodeJS version
  • Updated minimum Typescript version
  • Renamed magic prop

aaronccasanova and others added 8 commits December 12, 2023 09:16
@aaronccasanova
Remove Data URL and placeholder support from the Icon component (#1…
51791b0 
…1276)
[Icon] Remove text tones and update (#11356)
e8c2bc4 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Open it as a draft if it’s a work in progress
-->

### WHY are these changes introduced?

Part of https://github.com/Shopify/polaris-internal/issues/1265

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?


Remove stories with `toneText*` 

| Before | After |
| -- | -- | 

|![before](https://github.com/Shopify/polaris/assets/4642404/63749737-da8c-43ac-aac6-63219f95db7c)|![after](https://github.com/Shopify/polaris/assets/4642404/100f8057-88a2-4466-ba01-e4fa713daa88)|


Add example to polaris.shopify.com

<img width="1624" alt="Screenshot 2023-12-15 at 12 33 03 PM"
src="https://github.com/Shopify/polaris/assets/4642404/2a29b979-9bd5-4d1f-bf2b-a056082542d8">


⚠️ Will need to check other shopify codebases and migrate

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

  Include a video if your changes include interactive content.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

  <details>
    <summary>Summary of your gif(s)</summary>
    <img src="..." alt="Description of what the gif shows">
  </details>
-->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
@aaronccasanova
Init v13 migration guide with Inter v4 updates (#11414)
ae7c5f9
@aaronccasanova
Rename migrating-from-v11-to-v13.mdx to migrating-from-v12-to-v13.mdx
7c5ade6
@alex-page
Merge branch 'main' into v13.0.0
4cc9d50
@alex-page
Remove SidekickIcon
4fc92be
@lgriffee
Add v13 font migration documentation (#11597)
a54c4d0 
### WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-internal/issues/1388
Fixes https://github.com/Shopify/polaris-internal/issues/1428
Related to #11596

### WHAT is this pull request doing?

Adds migration documentation for the removal of the `Text` `heading-3xl`
and `heading-2xl` variants/classes/alias tokens as well as associated
primitive tokens.

![Screenshot 2024-02-13 at 10 41
28 AM](https://github.com/Shopify/polaris/assets/21976492/cc83d845-2cf0-439c-a060-8ee6147ad2a7)

![Screenshot 2024-02-13 at 10 41
46 AM](https://github.com/Shopify/polaris/assets/21976492/f36826c6-4ccd-486b-8297-165c7f43da19)
@lgriffee
Remove Text heading3xl and heading2xl variants and related prim…
85bc879 
…itive tokens (#11599)

### WHY are these changes introduced?

Fixes https://github.com/Shopify/polaris-internal/issues/1429

### WHAT is this pull request doing?

Removes the `Text` `heading3xl` and `heading2xl` variants and any
[related primitive
tokens](#11596).
@alex-page alex-page changed the title v13.0.0 v14.0.0 Apr 1, 2024
@lgriffee
[Text] Bring back heading2xl and associated tokens for mobile use-c…
f2bc2a1 
…ases (#11815)

### WHY are these changes introduced?

Part of https://github.com/Shopify/polaris-internal/issues/1529

### WHAT is this pull request doing?

Adds back the Text `heading2xl` variant since it will be kept in the
next major version for mobile purposes.
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-b-rose sam-b-rose Awaiting requested review from sam-b-rose sam-b-rose will be requested when the pull request is marked ready for review sam-b-rose is a code owner

@gwyneplaine gwyneplaine Awaiting requested review from gwyneplaine gwyneplaine will be requested when the pull request is marked ready for review gwyneplaine is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. no-pr-activity 🤖Skip Major Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-page @lgriffee @aaronccasanova