Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IndexTable]: clear all selection #11672

Open
wants to merge 13 commits into
base: test-drive/use-index-resouce-state-fast-follow
Choose a base branch
from

Conversation

lbenie
Copy link
Contributor

@lbenie lbenie commented Feb 28, 2024

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@lbenie
Copy link
Contributor Author

lbenie commented Feb 28, 2024

/snapit

@lbenie lbenie self-assigned this Feb 28, 2024
@lbenie
Copy link
Contributor Author

lbenie commented Feb 28, 2024

/snapit

1 similar comment
@lbenie
Copy link
Contributor Author

lbenie commented Feb 28, 2024

/snapit

Copy link
Contributor

🫰✨ Thanks @lbenie! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @shopify/[email protected]

@lbenie lbenie force-pushed the test-drive/clear-selection branch from 75253b7 to e957496 Compare March 18, 2024 20:41
@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Mar 18, 2024
@lbenie lbenie force-pushed the test-drive/use-index-resouce-state-fast-follow branch 2 times, most recently from 2968e00 to 82f1811 Compare March 19, 2024 18:21
@lbenie lbenie force-pushed the test-drive/clear-selection branch from e957496 to aaedc89 Compare March 19, 2024 18:27
@github-actions github-actions bot removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Mar 19, 2024
@lbenie
Copy link
Contributor Author

lbenie commented Mar 19, 2024

/snapit

1 similar comment
@lbenie
Copy link
Contributor Author

lbenie commented Mar 19, 2024

/snapit

Copy link
Contributor

🫰✨ Thanks @lbenie! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@lbenie
Copy link
Contributor Author

lbenie commented Mar 21, 2024

/snapit

1 similar comment
@lbenie
Copy link
Contributor Author

lbenie commented Mar 21, 2024

/snapit

Copy link
Contributor

🫰✨ Thanks @lbenie! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@lbenie
Copy link
Contributor Author

lbenie commented Mar 21, 2024

/snapit

Copy link
Contributor

🫰✨ Thanks @lbenie! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@lbenie lbenie force-pushed the test-drive/clear-selection branch from 00da666 to 43345f4 Compare March 25, 2024 14:34
@lbenie lbenie force-pushed the test-drive/clear-selection branch from 43345f4 to cc9c85e Compare March 25, 2024 14:48
@lbenie
Copy link
Contributor Author

lbenie commented Mar 25, 2024

/snapit

Copy link
Contributor

🫰✨ Thanks @lbenie! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@@ -229,6 +229,7 @@
"selectAllLabel": "Select all {resourceNamePlural}",
"selected": "{selectedItemsCount} selected",
"undo": "Undo",
"clearAll": "Clear selection",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization quality issue found

The following issues may affect the quality of localized translations if they are not addressed:

  • The value Clear selection for key Polaris.IndexTable.clearAll is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

@lbenie
Copy link
Contributor Author

lbenie commented Apr 3, 2024

/snapit

@lbenie
Copy link
Contributor Author

lbenie commented Apr 3, 2024

/snapit

@lbenie
Copy link
Contributor Author

lbenie commented Apr 3, 2024

/snapit

@lbenie
Copy link
Contributor Author

lbenie commented Apr 3, 2024

/snapit

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🫰✨ Thanks @lbenie! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-migrator": "0.0.0-snapshot-20240403193250"
"@shopify/polaris": "0.0.0-snapshot-20240403193250"
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240403193250"

@lbenie
Copy link
Contributor Author

lbenie commented Apr 3, 2024

/snapit

@lbenie
Copy link
Contributor Author

lbenie commented Apr 3, 2024

/snapit

Copy link
Contributor

github-actions bot commented Apr 3, 2024

🫰✨ Thanks @lbenie! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/polaris-migrator": "0.0.0-snapshot-20240403201001"
"@shopify/polaris": "0.0.0-snapshot-20240403201001"
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240403201001"

Copy link
Contributor

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant