-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IndexTable]: clear all selection #11672
base: test-drive/use-index-resouce-state-fast-follow
Are you sure you want to change the base?
[IndexTable]: clear all selection #11672
Conversation
/snapit |
/snapit |
1 similar comment
/snapit |
🫰✨ Thanks @lbenie! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @shopify/[email protected] |
75253b7
to
e957496
Compare
2968e00
to
82f1811
Compare
e957496
to
aaedc89
Compare
/snapit |
1 similar comment
/snapit |
🫰✨ Thanks @lbenie! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
/snapit |
1 similar comment
/snapit |
🫰✨ Thanks @lbenie! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
/snapit |
🫰✨ Thanks @lbenie! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
00da666
to
43345f4
Compare
43345f4
to
cc9c85e
Compare
/snapit |
🫰✨ Thanks @lbenie! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected] yarn add @shopify/[email protected] yarn add @shopify/[email protected] |
@@ -229,6 +229,7 @@ | |||
"selectAllLabel": "Select all {resourceNamePlural}", | |||
"selected": "{selectedItemsCount} selected", | |||
"undo": "Undo", | |||
"clearAll": "Clear selection", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Clear selection
for keyPolaris.IndexTable.clearAll
is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
/snapit |
/snapit |
/snapit |
/snapit |
🫰✨ Thanks @lbenie! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240403193250"
"@shopify/polaris": "0.0.0-snapshot-20240403193250"
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240403193250" |
/snapit |
/snapit |
🫰✨ Thanks @lbenie! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240403201001"
"@shopify/polaris": "0.0.0-snapshot-20240403201001"
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240403201001" |
3421fae
to
ea6ab22
Compare
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.md
with documentation changes