Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VF][Polaris] IndexTable row borders is configurable #11676

Closed
wants to merge 4 commits into from
Closed

[VF][Polaris] IndexTable row borders is configurable #11676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46efff4
added divider prop for Row, added story
oksanashopify Feb 29, 2024
869fd6e
fixed comments after rebase
oksanashopify Mar 15, 2024
58148c1
Removed cell border styles
oksanashopify Mar 16, 2024
804ca2c
removed extra styles for borderless
oksanashopify Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/purple-olives-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/polaris': patch
'polaris.shopify.com': patch
---

Added `borderless` property to the `Row` component to determine whether the row should have visible `border-top`
7 changes: 4 additions & 3 deletions polaris-react/src/components/IndexTable/IndexTable.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@
cursor: auto;
}

&.TableRow-borderless {
border: 0;
}

&.toneSuccess {
/* stylelint-disable-next-line selector-max-combinators, selector-max-class, selector-max-specificity -- generated by polaris-migrator DO NOT COPY */
&,
Expand Down Expand Up @@ -256,9 +260,6 @@
font-weight: var(--p-font-weight-medium);
font-size: var(--p-font-size-300);
background-color: var(--p-color-bg-surface-secondary);
border-top: var(--p-border-width-025) solid var(--p-color-border);
Copy link
Contributor Author

@oksanashopify oksanashopify Mar 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we can safely remove these borders. I would fix the following issue with doubled borders:
image

border-bottom: var(--p-border-width-025) solid var(--p-color-border);
border-color: var(--p-color-border);
}
}

Expand Down
Loading
Loading