Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Listbox, OptionList] Right align check icons on selected list items #11697

Merged
merged 6 commits into from
Apr 3, 2024
Merged

[Listbox, OptionList] Right align check icons on selected list items #11697

merged 6 commits into from
Apr 3, 2024

Commits on Mar 14, 2024

  1. chore: update listbox layout

    @kyledurand
    kyledurand committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1c74e9f View commit details
    Browse the repository at this point in the history

  2. chore: update Optionlist layout

    @kyledurand
    kyledurand committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    bbe4319 View commit details
    Browse the repository at this point in the history

  3. changeset

    @kyledurand
    kyledurand committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    64501aa View commit details
    Browse the repository at this point in the history

  4. fix up story

    @kyledurand
    kyledurand committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0f0cbeb View commit details
    Browse the repository at this point in the history

  5. update gap

    @kyledurand
    kyledurand committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    9196b83 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. [OptionList] Fix layout shift within popovers (#11736) 

    Fixes https://github.com/Shopify/polaris-internal/issues/1517

Open to other ideas on how to fix this but character width is the most
performant I can think of


https://github.com/Shopify/polaris/assets/6844391/268bc7c8-48ef-43ba-895f-b647a5a7b8c1
    @kyledurand
    kyledurand authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    276cd71 View commit details
    Browse the repository at this point in the history